Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uint64 bug in JSON transcoder #5

Merged

Conversation

wkalt
Copy link
Contributor

@wkalt wkalt commented Apr 22, 2024

This ports the bugfix from
foxglove/mcap#1159

@wkalt wkalt force-pushed the task/fix-uint64-bug-json-transcoder branch from 7beec1c to afe5195 Compare April 22, 2024 17:57
Copy link

@bryfox bryfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@defunctzombie defunctzombie merged commit e231891 into foxglove:main Apr 22, 2024
3 checks passed
bryfox added a commit to foxglove/foxglove-cli that referenced this pull request Apr 25, 2024
### Changelog

Fix uint64 handling in JSON transcoder

### Description

This bumps the go-rosbag dependency to v0.0.6, in order to get this fix:
foxglove/go-rosbag#5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants